Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][ADD] fieldservice_equipment_stock_return: add return order type #1241

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][ADD] fieldservice_equipment_stock_return: add return order type #1241

wants to merge 1 commit into from

Conversation

imlopes
Copy link

@imlopes imlopes commented Oct 21, 2024 •
edited
Loading

Initially this PR was adding a feature on the current module fieldservice_equipment_stock.
It seems more appropriate to create a separate module adding the return option on the equipments.

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @brian10048, @smangukiya, @wolfhall,
some modules you are maintaining are being modified, check this out!

@imlopes imlopes changed the title [17.0][IMP] fieldservice_euipment_stock: add return order type [17.0][IMP] fieldservice_equipment_stock: add return order type Oct 21, 2024
@max3903 max3903 added this to the 17.0 milestone Oct 21, 2024
@max3903 max3903 self-assigned this Oct 21, 2024
@max3903
Copy link
Member

max3903 commented Oct 21, 2024

@EdgarRetes Can you test and review?

@imlopes
Copy link
Author

imlopes commented Oct 21, 2024

Hello @max3903
I'm still working on that.

@imlopes imlopes force-pushed the 17.0-add-feat-service-return branch from 077e64d to b17b846 Compare October 21, 2024 18:44
@imlopes imlopes marked this pull request as ready for review October 21, 2024 18:49
@imlopes imlopes mentioned this pull request Oct 21, 2024
Open
@imlopes
Copy link
Author

imlopes commented Oct 21, 2024

#1229

@EdgarRetes
Copy link
Contributor

image
image
I get this error when trying to save a new field service order

@imlopes imlopes force-pushed the 17.0-add-feat-service-return branch 2 times, most recently from a991d94 to f63eb8c Compare October 21, 2024 20:31
@imlopes
Copy link
Author

imlopes commented Oct 21, 2024

@EdgarRetes if/when tests are OK, you can re-test.
autocomplete error :s

@EdgarRetes
Copy link
Contributor

@EdgarRetes if/when tests are OK, you can re-test. autocomplete error :s

Looks good to me

gurneyalex
gurneyalex reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@gurneyalex gurneyalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test exercising the new code.

Please update readme/USAGE.md to include something along the line of

"""The Return field service order type can be used to create a field service order to dispatch someone to pickup an equipment in its current location. From the order, it is possible to create an incoming stock picking to record the return of the equipment."""

fieldservice_equipment_stock/models/fsm_order.py Outdated Show resolved Hide resolved
@imlopes imlopes force-pushed the 17.0-add-feat-service-return branch from f63eb8c to 755ae2b Compare October 29, 2024 14:12
@imlopes imlopes changed the title [17.0][IMP] fieldservice_equipment_stock: add return order type [17.0][ADD] fieldservice_equipment_stock_return: add return order type Oct 29, 2024
@imlopes imlopes force-pushed the 17.0-add-feat-service-return branch from 755ae2b to 8dfd9eb Compare October 29, 2024 15:38
@imlopes imlopes force-pushed the 17.0-add-feat-service-return branch 4 times, most recently from ce0d3b7 to b440329 Compare October 29, 2024 17:25
@imlopes imlopes force-pushed the 17.0-add-feat-service-return branch from b440329 to f7df6d1 Compare October 30, 2024 11:33
@imlopes imlopes requested a review from vvrossem October 30, 2024 11:33
@imlopes
Copy link
Author

imlopes commented Oct 30, 2024 •
edited
Loading

Hello @max3903,
Can you check this PR, please ?
Normally it was tested by @EdgarRetes but I did changes, removing the code from fieldservice_equipment_stock and adding a new one fieldservice_equipment_stock_return.

Thanks a lot

@max3903
Copy link
Member

max3903 commented Oct 30, 2024

@imlopes LGTM Can you update the icon?

https://github.com/OCA/field-service/blob/17.0/fieldservice/static/description/icon.png

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@max3903 max3903 max3903 approved these changes

@gurneyalex gurneyalex Awaiting requested review from gurneyalex

@vvrossem vvrossem Awaiting requested review from vvrossem

Assignees

@max3903 max3903

Labels
approved enhancement needs review ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@imlopes @OCA-git-bot @max3903 @EdgarRetes @ivantodorovich @gurneyalex @vvrossem